How bad is holding in your pee? For years?

Yes, it's really bad to hold your urine. Persistent UTI's aren't good either. They can cause permanent damage to your body, as well as taking too many antibiotics. Pretty soon you could become resistant to antibiotics, which could be deadly if you ever get a severe infection of some sort. Please don't continue this or you could suffer some awful consequences.